spacepaste

Paste details

reply | raw | toggle line wrapping

  1.  
  2. From 1ac17bea2273df0dfec21897b00efb8351648e1b Mon Sep 17 00:00:00 2001
  3. From: Kent Fredric <kentnl@gentoo.org>
  4. Date: Sun, 9 Apr 2017 04:10:52 +1200
  5. Subject: Remove need for threaded perl at expense of being single-threaded
  7. This could theoretically be implemented with forks, but I opted not
  8. to because its too hard, and the platform specifics are too messy.
  10. This could theoretically also have support for automatic detection
  11. as to which strategy to use based on OS/availability, but the
  12. implementation details of that are too much for my pateience today.
  14. In an ideal world, this file would support:
  16. 1. Single threaded builds for spartans
  17. 2. Forked builds for people who are on linux but don't want to rebuild
  18. their perl just to have threads ( which produce negligible benefit
  19. and measurable performance penalties to all code )
  20. 3. Threaded builds for people who are on windows where forks may not
  21. be entirely sane.
  23. But #1 is good enough atm.
  25. This is important for Gentoo, because end users decide on their own
  26. choices with regards to threading support for perl, and threading
  27. support is off by default due to the performance issues mentioned in #2
  28. in conjunction with the fact that "threads" is officially discouraged
  29. by Perl Upstream.
  31. And as Gentoo users have to have a system Perl to compile WebkitGTK,
  32. this means installing WebkitGTK requires rebuilding their system Perl
  33. with threads.
  35. And this *also* means that all packages presently compiled against Perl
  36. become broken, because non-threaded perl and threaded perl are not ABI
  37. compatible with each other, and this can scale into hundreds of
  38. packages and significant transient breakage.
  40. This ends up in practice being *far* *worse* in terms of time wasted
  41. than the mediocre time inefficiency created by needing a single
  42. threaded build.
  43. ---
  44. Source/WebCore/bindings/scripts/generate-bindings-all.pl | 15 +++++----------
  45. 1 file changed, 5 insertions(+), 10 deletions(-)
  47. diff --git a/Source/WebCore/bindings/scripts/generate-bindings-all.pl b/Source/WebCore/bindings/scripts/generate-bindings-all.pl
  48. index 37b27cc74..b3a378df0 100755
  49. --- a/Source/WebCore/bindings/scripts/generate-bindings-all.pl
  50. +++ b/Source/WebCore/bindings/scripts/generate-bindings-all.pl
  51. @@ -32,9 +32,6 @@ use File::Basename;
  52. use File::Spec;
  53. use File::Find;
  54. use Getopt::Long;
  55. -use threads;
  56. -use threads::shared;
  57. -use Thread::Queue;
  59. my $perl = $^X;
  60. my $scriptDir = $FindBin::Bin;
  61. @@ -121,13 +118,11 @@ my @idlFilesToUpdate = grep &{sub {
  62. implicitDependencies($depFile));
  63. needsUpdate(\@output, \@deps);
  64. }}, @idlFiles;
  65. -my $queue = Thread::Queue->new(@idlFilesToUpdate);
  66. -my $abort :shared = 0;
  67. -my $totalCount = @idlFilesToUpdate;
  68. -my $currentCount :shared = 0;
  70. -my @threadPool = map { threads->create(\&worker) } (1 .. $numOfJobs);
  71. -$_->join for @threadPool;
  72. +my $abort = 0;
  73. +my $totalCount = @idlFilesToUpdate;
  74. +my $currentCount = 0;
  75. +worker();
  76. exit $abort;
  78. sub needsUpdate
  79. @@ -158,7 +153,7 @@ sub mtime
  80. }
  82. sub worker {
  83. - while (my $file = $queue->dequeue_nb()) {
  84. + while (my $file = shift @idlFilesToUpdate) {
  85. last if $abort;
  86. eval {
  87. $currentCount++;
  88. --
  89. 2.12.2
  90.  
Powered by spacepaste. Paste removal.